Fixed #1769 Suggest to rename the image name #2245
Open
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivangMishra
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #2245 (2023-09-01T08:20:32Z) ⚙️ JKube E2E Tests (6046868103)
|
Codecov Report
@@ Coverage Diff @@
## master #2245 +/- ##
============================================
+ Coverage 59.36% 59.86% +0.50%
- Complexity 4586 4611 +25
============================================
Files 500 505 +5
Lines 21211 21043 -168
Branches 2830 2785 -45
============================================
+ Hits 12591 12597 +6
+ Misses 7370 7231 -139
+ Partials 1250 1215 -35
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| String message = "Error while trying to push the image: " + ex.getMessage() + | ||
| "\nPossible issue: wrong image name or registry." + | ||
| "\nHint: Rename image name or registry with the jkube.generator.name property = registry name and user name and image name"; | ||
| throw new JKubeServiceException(message, ex); |
There was a problem hiding this comment.
I don't think we should always log this warning. IOException could also mean problems with network. It would be better if we could rely on docker response codes. If not you can check the exception message for keywords like unauthorized/denied etc.
There was a problem hiding this comment.
We also need to do the same for JibBuildService as well.
|
@rohanKanojia is it okay now? |
|
Kudos, SonarCloud Quality Gate passed! |
|
@sunix can you please review and merge this PR? |
|
Sun is on PTO. However, did Rohan approve based on the changes you made? (if not, please don't ask someone else to 'merge') |
I made the changes that he suggested. Didn't get a reply from @rohanKanojia on this. I'll check with him again. |
|
Don't worry. I spoke with him yesterday. He will review when available. Just making sure we do not miss addressing comments. |
|
@rohanKanojia should I squash the commits on this PR? |
|
I tested it on DockerHub, Quay.io and GitHub Container Registry, it seems to be working okay. I think if a user gets unauthorized error, there are two possibilities:
I think we should print two hints instead of one. |
|
Could you please add some unit tests for this? Maybe we should try to move this logic to some common place to avoid duplication. |
sunix
reviewed
Aug 29, 2023
...ervice/src/main/java/org/eclipse/jkube/kit/config/service/kubernetes/DockerBuildService.java
Outdated
Show resolved
Hide resolved
ShivangMishra
force-pushed
the
issue-1769
branch
from
1f43d07
to
528af16
Compare
|
TODO for this issue: debug with docker and jib, extract the error and create unit test based on the extracted error. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sh task fails
Description
Fixes #1769
Type of change
test, version modification, documentation, etc.)
Checklist